Fix linting on delphi utils #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
krivard
reviewed
Nov 9, 2020
| self, data, zip_col="zip", msa_col="msa", date_col="date", count_cols=None | ||
| self, data, zip_col="zip", date_col="date", count_cols=None |
There was a problem hiding this comment.
that variable is unused in that function.
There was a problem hiding this comment.
Do we know if any indicators call it with that keyword?
There was a problem hiding this comment.
Didn't find any uses when I searched, only saw use of the zip_to_msa function below it, which calls convert_zip_to_msa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
One outstanding linting error not included in this PR, will be fixed by #460