Skip to content

Fix linting for google symptoms #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Fix linting for google symptoms #455

merged 2 commits into from
Nov 6, 2020

Conversation

chinandrew
Copy link
Contributor

Gets pylint to pass

Summary of changes:

  • fix any small linting errors (whitespace, newlines, etc)
  • ignore the larger lint errors that would require more refactoring (access protected class, etc)

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -21,7 +21,7 @@ def generate_transition_matrix(geo_res):
The first is a data frame for HRR regions and the second are MSA
regions.
"""
map_df = gmpr._load_crosswalk("fips", geo_res)
map_df = gmpr._load_crosswalk("fips", geo_res) # pylint: disable=W0212
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this one is fine; google_symptoms is deprecated anyway)

@krivard krivard merged commit a3a9131 into main Nov 6, 2020
@krivard krivard deleted the gsymptoms-lint branch November 6, 2020 21:04
@chinandrew chinandrew mentioned this pull request Nov 9, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants