Skip to content

Add CI for python #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Add CI for python #449

merged 2 commits into from
Nov 6, 2020

Conversation

chinandrew
Copy link
Contributor

@chinandrew chinandrew commented Nov 6, 2020

Blocked by #443, which is currently merged into this branch since we use the make commands. The only actual change in this pr should be the workflow yaml

Summary of changes:

  • Add workflows for all production indicators
  • Google health is excluded since it is deprecated and also makes network calls in tests, though shouldn't be too much work if we want to spend the time to add it.
  • Delphi utils is commented out until Fix matrix inversion bug on smoother unit tests #448
  • linting is commented out while I work on PR's to get them all to pass

There's a handful of small optimizations that could be made to the workflow, but I think things will slightly change anyway as we tune linting and see how various commands work.

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chinandrew chinandrew changed the base branch from main to add-pylint November 6, 2020 19:50
@chinandrew chinandrew changed the base branch from add-pylint to main November 6, 2020 19:50
@krivard krivard merged commit cd865d0 into main Nov 6, 2020
@krivard krivard deleted the add-ci branch November 6, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants