Skip to content

Refactor CHC to use smoothing utils #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 11, 2020
Merged

Refactor CHC to use smoothing utils #431

merged 9 commits into from
Nov 11, 2020

Conversation

chinandrew
Copy link
Contributor

@chinandrew chinandrew commented Nov 4, 2020 •
edited
Loading

Closes #430

Summary of Changes:

  • Update Change to use new smoothing utils
  • Update test to smooth on test data

@chinandrew
Copy link
Contributor Author

blocked by #437

@krivard krivard added the blocked This task is waiting for completion of another task label Nov 5, 2020
This was referenced Nov 9, 2020
Closed
Merged
@chinandrew chinandrew marked this pull request as draft November 10, 2020 16:18
@chinandrew chinandrew marked this pull request as ready for review November 10, 2020 16:18
@chinandrew chinandrew marked this pull request as draft November 10, 2020 16:38
@chinandrew chinandrew marked this pull request as ready for review November 10, 2020 16:38
@krivard krivard requested a review from rumackaaron November 10, 2020 20:57
@rumackaaron
Copy link
Contributor

I'm getting some linting errors, but I assume they were fixed by #463

@rumackaaron
Copy link
Contributor

The refactor itself looks good and the tests pass

@chinandrew
Copy link
Contributor Author

Just merged main in, passing on my end now.

@rumackaaron
Copy link
Contributor

Passing for me too

@krivard krivard merged commit 35ab469 into main Nov 11, 2020
@krivard krivard deleted the change-smooth-refactor branch November 11, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumackaaron rumackaaron rumackaaron approved these changes

Assignees
No one assigned
Labels
blocked This task is waiting for completion of another task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

changehc - smoothing refactor
3 participants
@chinandrew @rumackaaron @krivard