Find Unexpected Values for geo_id #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code to validate that all geo_id values are valid, by comparing against a list of known values.
- Clarify format vs. value checks - move files from csv/ -> static/
Renamed directory and file (unique_geoids.R) is now expected to be run from within the directory instead of from one level up.
|
@nmdefries as suggested reviewer, since I cannot set it directly. |
nmdefries
reviewed
Nov 3, 2020
Comment on lines
263
to
264
| unexpected_geos, "Unrecognized geo_ids (not in historical data)")) | ||
|
|
There was a problem hiding this comment.
Increment check counter with self.increment_total_checks().
There was a problem hiding this comment.
Does this still need to be fixed?
There was a problem hiding this comment.
Fixed in latest commit
There was a problem hiding this comment.
Yep, waiting on this and a few other changes!
nmdefries
reviewed
Nov 3, 2020
There was a problem hiding this comment.
Looks good! There are just a few cleanup items left.
- Write some tests to check behavior of this function. You can put tests in tests/test_checks.py
- Apply any check name changes to method calls in tests/test_checks.py. There are a few trivial failures right now.
|
Added changes in response to comments. Please verify by running tests before merging. |
nmdefries
reviewed
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Due to technical issues I was not able to run the validator to test this. Looking for code to be run in addition to reviewed.