Skip to content

Update quidel covidtest docstrings to pass pydocstyle #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

chinandrew
Copy link
Contributor

Summary of changes:

  • Update docstrings so they pass the pydocstyle linter, which checks against most of PEP257
  • geomapping and data tools (smoothing) functions are excluded until refactors go through

@chinandrew chinandrew added the documentation Improvements or additions to documentation label Oct 27, 2020
@krivard krivard requested a review from jingjtang October 28, 2020 13:02
@jingjtang
Copy link
Contributor

@chinandrew quidel_covidtest is branch that is more up-to-date and is also the branch that is used for automation, can you merge this to that branch instead of main ?

@chinandrew chinandrew changed the base branch from main to quidel_covidtest October 28, 2020 15:19
@chinandrew chinandrew changed the base branch from quidel_covidtest to main October 28, 2020 15:19
@chinandrew
Copy link
Contributor Author

@chinandrew quidel_covidtest is branch that is more up-to-date and is also the branch that is used for automation, can you merge this to that branch instead of main ?

Got it. Does everything for quidel_covidtest get merged into that branch? I think I'm missing something about the automation processes.

@jingjtang
Copy link
Contributor

@chinandrew quidel_covidtest is branch that is more up-to-date and is also the branch that is used for automation, can you merge this to that branch instead of main ?

Got it. Does everything for quidel_covidtest get merged into that branch? I think I'm missing something about the automation processes.

Yes, quidel_covidtest branch should be the most up-to-date one. The automation should be in deploy-quidel branch which is based on quidel_covidtest currently. When we have deletion support in the system, the automation will switch to run-quidel branch. And finally we will remove quidel_covidtest and quidel_flutest branches.

@chinandrew
Copy link
Contributor Author

Does main not factor in at all? I though the deploy branches got main merged into them regularly.

@jingjtang
Copy link
Contributor

Does main not factor in at all? I though the deploy branches got main merged into them regularly.

In my experience, at least not the case for ght (using run-ght) and quidel (currently using quidel_covidtest).

@chinandrew
Copy link
Contributor Author

In my experience, at least not the case for ght (using run-ght) and quidel (currently using quidel_covidtest).

Interesting, thanks for explaining. @krivard how should we think about the version of quidel in main? Do we want to get them sync'd?

@krivard
Copy link
Contributor

krivard commented Nov 2, 2020

The workflow we had in mind with the current deployment system is broken, but looks like this:

  • branch from main
  • write some code
  • PR into deploy-*
  • PR deploy-* into main

This workflow is not usable with full-time developers who motor through fixes at the rate we currently do. We're currently using a modified workflow which is less broken, but far from ideal:

  • branch from main
  • write some code
  • PR into main
  • periodically PR main into deploy-*

Both workflows rely on main representing the currently deployed or imminently-deployed system. That is the only way we can be assured that bugfixes in the central utility library will get picked up by the individual indicators.

@chinandrew
Copy link
Contributor Author

going to close this until we figure out branching

@chinandrew chinandrew closed this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants