Switch to geo utils for combined Quidel pipeline #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
reviewed
Oct 14, 2020
quidel/delphi_quidel/run.py
Outdated
| @@ -4,9 +4,6 @@ | |||
| This module should contain a function called `run_module`, that is executed | |||
| when the module is run with `python -m MODULE_NAME`. | |||
nmdefries
reviewed
Oct 14, 2020
There was a problem hiding this comment.
You're getting a fair number of errors/warnings from pylint. Most of them are of the "too many arguments" and "doesn't conform to snake_case" type, but here are a few that might impact result accuracy:
delphi_quidel/geo_maps.py:33:20: W0212: Access to a protected member _load_crosswalk of a client class (protected-access)
delphi_quidel/geo_maps.py:35:18: E1136: Value 'fips_to_state' is unsubscriptable (unsubscriptable-object)
delphi_quidel/geo_maps.py:37:26: W0212: Access to a protected member _load_crosswalk of a client class (protected-access)
delphi_quidel/geo_maps.py:39:16: E1136: Value 'fips_to_state' is unsubscriptable (unsubscriptable-object)
This one is dangerous because you might intercept an exception type you weren't expecting:
delphi_quidel/generate_sensor.py:96:8: W0702: No exception type(s) specified (bare-except)
Test coverage is good and all tests pass.
A bit more docstring coverage would be nice. Some of the docstrings are also out of date (list arguments that no longer exist or go by different names now).
Good division of functions into topic-separated files!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #253