-
Notifications
You must be signed in to change notification settings - Fork 16
EMR: standard signal names #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few style things and some nits (i apologize, i have OCD).
if you intend for the two copies of 02_20_uszips.csv to be identical, perhaps they should symlink to each other to keep stuff in sync?
otherwise, it looks good and the logic is sound!
reminder to let us know whether unit tests pass -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (assuming all tests pass, of course)
Tests all pass on my end. Sorry I can't look at the code deeply this time! |
No description provided.