Skip to content

Diff uploads usafacts #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 75 commits into from
Aug 31, 2020
Merged

Diff uploads usafacts #234

merged 75 commits into from
Aug 31, 2020

Conversation

vishakha1812
Copy link
Contributor

No description provided.

Jingjing Tang and others added 30 commits July 15, 2020 12:06
add code
b67c26a
add unittests
332ec54
update tests
9aef490
fix a bug and add test_pull
28ba922
update unittest
71d5c68
udpate code
c2e07cc
fixed errors in README
3c3855e
update unittests
c59f068
udpate params template file
5a096ce
udpate readme file
d04bac9
@jingjtang
Add "wip" in the name of smoothed signal
b5f77d7
modify code
86b0789
add gitignore
7741ff6
move two dependencies into setup.py
861d6a1
add detailed description
e7ad84e
udpate description
9468c97
add whitespace to DETAILS
dd4ce38
@jingjtang
Update DETAILS.md
239144a
@jingjtang
Fixed a bug in setup.py
e433e52
@jingjtang
Fixed a bug in the setup.py
8080715
update code
fb52548
udpate unittests
fa0b940
created folders for tests
821f93b
@jingjtang
Delete .gitignore
9eba114
update unittests
4cf437b
fixed an error
c633b0e
@jingjtang
Update setup.py
5dd497f
@jingjtang
Removed commented lines
a32a4f1
@jingjtang
Update DETAILS.md
36ea688
@krivard
Merge pull request #154 from cmu-delphi/quidel_covidtest
fae9e1d 
pipeline for Quidel covidtest
vishakha1812 and others added 22 commits August 7, 2020 14:59
@vishakha1812
handling wip signal in python template
cc92195
@vishakha1812
Minor changes in process.py, updated test cases
2e580d1
@eujing
Added some NaNs to tests to verify behavior
8cac767
@krivard
Merge pull request #185 from cmu-delphi/diff-uploads
65dfc43 
Diffing and archiving utilities
@krivard
Supply missing params.json.template in tests
e28d224
@krivard
Switch from raw Epidata client to COVIDcast client
4d3bc3e
@krivard
Move signal name constants to their own file, referenced from both ru…
eb19aa4 
…n.py and process.py
@vishakha1812
Merge pull request #204 from cmu-delphi/kmm/rename_signals
ef88218 
Kmm/rename signals
@krivard
Corrected logic to comply with #113
fb97ec2 
* Also converted unit test to test the process.py logic instead of the validity of the params file.
* Corrected errors I'd introduced in the conversion to covidcast client
@vishakha1812
Merge pull request #205 from cmu-delphi/kmm/rename_signals
2634f00 
Corrected logic to comply with #113
@vishakha1812
changes in compliance with #205
fe3efab
@vishakha1812
Missing comma in setup.py
b42fa14
@vishakha1812
Linter suggested changes, added HOME_DWELL signal computation
b972968
@krivard
Merge pull request #167 from cmu-delphi/fix-cdc-covidnet-test
24e8f6d 
Fix test affected by backfill for CDC Covidnet
@vishakha1812
default prefix value
7d9a59a
@vishakha1812 @krivard
Apply suggestions from code review
9e637c9 
Co-authored-by: krivard <[email protected]>
@vishakha1812
Removed unnecessary comment
c2643e5
@krivard
Merge pull request #195 from cmu-delphi/handle_wip_signals
eed8564 
handling wip signal in python template
@krivard
Merge pull request #168 from cmu-delphi/rename_signals
31d882b 
safegraph: standardizing signal names
@eujing
Added archiving diffing utility
911c0e0
@eujing
Updated unit tests
5d3b8ec
@eujing
Updated ansible template
2d3fb80
@vishakha1812 vishakha1812 marked this pull request as ready for review August 21, 2020 19:17
@krivard
Copy link
Contributor

krivard commented Aug 21, 2020 •
edited
Loading

Should we merge these into main first?

Don't mind me, I'm just musing about workflow. Would this be easier to do if we ran the following in sequence:

  • PR from main to deploy-usafacts (which in theory doesn't touch the usafacts code)
  • PR from diff-uploads-usafacts to deploy-usafacts (which does)

@vishakha1812
Copy link
Contributor Author

Yup. we can do that to avoid future conflicts. Creating a PR: main --> deploy-usafacts

@vishakha1812
Copy link
Contributor Author

vishakha1812 commented Aug 21, 2020 •
edited
Loading

Build tests are failing in creating PR: main --> deploy-usafacts
Update: merged main --> deploy-usafacts
This PR can be merged.

@krivard krivard merged commit d8c7019 into deploy-usafacts Aug 31, 2020
@krivard krivard deleted the diff-uploads-usafacts branch October 29, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korlaxxalrok korlaxxalrok Awaiting requested review from korlaxxalrok

@krivard krivard Awaiting requested review from krivard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishakha1812 @krivard @jingjtang @eujing