Skip to content

2129 fix hrr for nssp #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 11, 2025
Merged

2129 fix hrr for nssp #2131

merged 14 commits into from
Mar 11, 2025

Conversation

aysim319
Copy link
Contributor

@aysim319 aysim319 commented Mar 3, 2025

Description

cleaning up test and fixing geo aggregation for hrr

Associated Issue(s)

@aysim319 aysim319 requested a review from nmdefries March 3, 2025 21:27
@aysim319 aysim319 linked an issue Mar 3, 2025 that may be closed by this pull request
@melange396 melange396 self-requested a review March 3, 2025 22:07
@aysim319 aysim319 requested a review from melange396 March 4, 2025 16:01
@aysim319 aysim319 dismissed melange396’s stale review March 5, 2025 15:28

applied requested changes and want to see how the build runs (currently blocked by pending request)

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic in the elif geo == "hrr": section looks good... can you describe whats going on with the changes to tests and with the txt/json files?

Copy link
Contributor

@minhkhul minhkhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Appreciate the addition of full run module tests.
[nonblocking] suggesting some extra docstrings for clarity.

@aysim319 aysim319 merged commit aa52e44 into main Mar 11, 2025
14 of 17 checks passed
@aysim319 aysim319 deleted the 2129-fix-hrr-for-nssp branch March 11, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSSP data for HRRs is not summed properly
3 participants