-
Notifications
You must be signed in to change notification settings - Fork 16
2129 fix hrr for nssp #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2129 fix hrr for nssp #2131
Conversation
applied requested changes and want to see how the build runs (currently blocked by pending request)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logic in the elif geo == "hrr":
section looks good... can you describe whats going on with the changes to tests and with the txt/json files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Appreciate the addition of full run module tests.
[nonblocking] suggesting some extra docstrings for clarity.
Co-authored-by: minhkhul <[email protected]>
Description
cleaning up test and fixing geo aggregation for hrr
Associated Issue(s)