Add more specifics about CI/CD, secrets, and params to indicator dev guide #2035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhkhul
approved these changes
Aug 26, 2024
| @@ -472,14 +472,17 @@ Refer to [this guide](https://docs.google.com/document/d/1Bbuvtoxowt7x2_8USx_JY- | |||
|
|
|||
| * Add module name to the `build` job in `.github/workflows/python-ci.yml`. | |||
| This allows github actions to run on this indicator code, which includes unit tests and linting. | |||
| * Add top-level directory name to `indicator_list` in `Jenkinsfile`. | |||
| * Add module name to the ["Copy version to indicator directory" step](https://github.com/cmu-delphi/covidcast-indicators/blob/f01185767a9847d8082baf4f1e17be50a39047c2/.github/workflows/create-release.yml#L64) in `.github/workflows/create-release.yml`. | |||
There was a problem hiding this comment.
Thanks for catching this!
nmdefries
merged commit a3ad367
into
ndefries/patching-in-indicator-manual
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more specifics about CI/CD, secrets, and params to indicator dev guide
Changelog
INDICATOR_DEV_GUIDE.mdAssociated Issue(s)
Closes #1969