Skip to content

google-symptoms patching fn should not return data for the 4 days immediately before the issue date #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 30, 2024
Merged

google-symptoms patching fn should not return data for the 4 days immediately before the issue date #2007

merged 9 commits into from
Jul 30, 2024

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jul 30, 2024 •
edited
Loading

Description

Plus simplify some tests. Add in "gold standard" data from our actual API to verify patching behavior. Some formatting cleanup.

@nmdefries nmdefries changed the title Ndefries/google symptoms patching fn google-symptoms patching fn should not return data for the 4 days immediately before the issue date Jul 30, 2024
@nmdefries nmdefries marked this pull request as ready for review July 30, 2024 14:20
@nmdefries nmdefries requested a review from aysim319 July 30, 2024 14:20
@nmdefries nmdefries mentioned this pull request Jul 30, 2024
Merged
@aysim319
Copy link
Contributor

aysim319 commented Jul 30, 2024 •
edited
Loading

line 14 the parameter return changed to Dict[date, Dict[str, Union[date, int]] date_utils
I'll change it after the merge; note to self

aysim319
aysim319 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@aysim319 aysim319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was so caught up with the "replicating" the logic and made it more complicated; also I should've asked about the lag; felt like I thought about it for a second and then forgot and spent waaay too much time trying to replicate the date range

@aysim319 aysim319 merged commit 8049cb0 into 1996-patch-google-symptoms Jul 30, 2024
3 checks passed
@aysim319 aysim319 deleted the ndefries/google-symptoms-patching-fn branch July 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aysim319 aysim319 aysim319 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmdefries @aysim319