Skip to content

Remove usage of PHP alias in the Python client #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rzats
Copy link
Contributor

@rzats rzats commented Sep 22, 2023

Secondary PR to cmu-delphi/delphi-epidata#1288 that should be merged & deployed alongside it - fixes breaking changes caused by the transition from "compatibility mode" / api.php in the Delphi Python client.

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should pin the version of the delphi-epidata package here too, as done in cmu-delphi/covidcast#663. Im guessing the usage of that package in "nowcast/" is luckily covered by inheriting from a line in hhs_hosp/setup.py, but nowcast/setup.py should have its own pin too.

@melange396
Copy link
Contributor

It looks like maybe you didnt get to run tests for this with the updated client from cmu-delphi/delphi-epidata#1288 ? Im pretty sure youll need to update the args to assert_called_once_with() for the @patched async_epidata():

mock_epidata.assert_called_once_with([
{"source": "covidcast",

@melange396
Copy link
Contributor

since we changed cmu-delphi/delphi-epidata#1288 to preserve the function signature of async_epidata(), shall we just abandon this PR?

@melange396 melange396 closed this Oct 9, 2023
@melange396 melange396 deleted the rzatserkovnyi/api-php-refactor branch October 9, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants