Skip to content

JHU deactivation: geomap + validator #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2023
Merged

JHU deactivation: geomap + validator #1831

merged 3 commits into from
Apr 14, 2023

Conversation

minhkhul
Copy link
Contributor

@minhkhul minhkhul commented Apr 12, 2023

Description

Remove JHU presence from geomap.
Warn readers of JHU deactivation upon running related code in utils.

For all other JHU deactivation-related removals, look here: #1818

@minhkhul minhkhul requested a review from dshemetov April 12, 2023 20:35
@minhkhul minhkhul mentioned this pull request Apr 12, 2023
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this! (I moved the geomapper notebook to _delphi_utils, so it's easier to find, I doubt anyone looks in testing_utils.)

@minhkhul minhkhul merged commit 1f4f352 into main Apr 14, 2023
@dshemetov dshemetov deleted the jhu-deactivation branch November 15, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants