Add age signals to SirCal params templates #1826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add age signals to Sir ComplainsAlot's Quidel parameters section
retired-signals
. This should suppress the errors regarding the age-specific signals, but leave thecovid_ag_raw_pct_positive
andcovid_ag_smoothed_pct_positive
visible.It appears the actual Quidel outage started on 4/6, but before this a few age signals were experiencing known errors. This caused the actual outage to go under the radar for a couple days as it looked like a known issue.
One review topic: Should we change the name of
retired-signals
to something along the lines ofskipped-signals
? It appears there are legitimate retired signals in this section, but this section of parameters seems to just be suppressing these signals on the SirCal side.Changelog
Fixes