Skip to content

Add age signals to SirCal params templates #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

M5Skid
Copy link
Contributor

@M5Skid M5Skid commented Apr 11, 2023

Description

Add age signals to Sir ComplainsAlot's Quidel parameters section retired-signals. This should suppress the errors regarding the age-specific signals, but leave the covid_ag_raw_pct_positive and covid_ag_smoothed_pct_positive visible.

It appears the actual Quidel outage started on 4/6, but before this a few age signals were experiencing known errors. This caused the actual outage to go under the radar for a couple days as it looked like a known issue.

One review topic: Should we change the name of retired-signals to something along the lines of skipped-signals? It appears there are legitimate retired signals in this section, but this section of parameters seems to just be suppressing these signals on the SirCal side.

Changelog

  • params.json.template (sircal)
  • sir_complainsalot-params-prod.json.j2
    • added signals to "retired-signals" for both files.

Fixes

  • Improves monitoring for Quidel signals

@M5Skid M5Skid requested review from krivard and neul3 April 11, 2023 17:31
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard krivard merged commit 87a18d7 into cmu-delphi:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants