Skip to content

[Backfill corrections] Use faster deduplicate fn for QC #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 6, 2023

Conversation

nmdefries
Copy link
Contributor

Description

Switch to faster dplyr::distinct for deduplication and move rough lag-based filter up before QC checks.

Changelog

  • main.R
  • utils.R

@nmdefries nmdefries requested a review from jingjtang April 4, 2023 16:14
@nmdefries
Copy link
Contributor Author

Test failures are related to hhs hosp.

Copy link
Contributor

@jingjtang jingjtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmdefries
Copy link
Contributor Author

@krivard This is ready to merge.

@krivard krivard merged commit 1647ea2 into main Apr 6, 2023
@krivard krivard deleted the ndefries/backfill/speed3 branch April 6, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants