Skip to content

[Backfill corrections] Convert dates-as-strings to Date types #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

nmdefries
Copy link
Contributor

Description

Support new input data format. After reading in data from a parquet file, convert time_value and issue_date fields from string to Dates.

Extend support of passing column names as args. Date conversions are applied to columns that are referred to in run_backfill() with col name variables. main() and functions that main() calls currently reference these with hard-coded names. Modify main and check functions to accept and use custom col names for issue_date, lag, and time_value fields.

Changelog

  • NAMESPACE
  • main.R
  • utils.R

@nmdefries nmdefries requested a review from jingjtang January 20, 2023 21:45
Copy link
Contributor

@jingjtang jingjtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmdefries
Copy link
Contributor Author

@krivard This is ready to merge

@krivard krivard merged commit 38adec3 into main Jan 23, 2023
@krivard krivard deleted the ndefries/backfill/date-as-str branch January 23, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants