Skip to content

Issue1746 validator no output #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 27, 2023

Conversation

M5Skid
Copy link
Contributor

@M5Skid M5Skid commented Jan 4, 2023

Description

Adds if loops to check for an empty file list before performing validation. An empty file list will throw a validation error instead of an exception. This can be set as a suppress-able error in params.json:

  • "suppressed_errors": [
    {"check_name": "check_empty_filelist"}
    ]

Changelog

static.py

  • Adds check for empty file list ("check_empty_filelist"), which will throw a validation failure if not suppressed.
  • "check_missing_date_files" check only takes place if the file list is not empty.

validate.py

  • Adds check for empty file list before calling aggregate_frames function.
  • If list is empty, an empty dataframe is passed to avoid the concatenation exception.

test-static.py

  • Changed name of test that will give a validation error. Empty file list test will now get the expected error on testing as part of the "check_empty_filelist" check.

Fixes

@M5Skid M5Skid requested review from krivard and neul3 January 4, 2023 14:42
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always nice when you can find a simple fix -- good work!

M5Skid and others added 3 commits January 24, 2023 16:47
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard krivard merged commit 651c048 into cmu-delphi:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator throws an exception when no output is produced by the indicator
2 participants