Make CPR hospital admissions header filter more specific #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krivard
approved these changes
Mar 3, 2022
| header.find(" beds") < 0, | ||
| ])) or (all([ | ||
| # exclude "Confirmed COVID-19 admissions per 100k - last 7 days" | ||
| header == "Confirmed COVID-19 admissions - last 7 days" |
There was a problem hiding this comment.
I have confirmed through exhaustive checking that this is the only header ever used for the column we want, across all sheets and all dates up to 2022-02-24. A refreshing degree of consistency for this report!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CPR recently changed the column "Confirmed COVID-19 admissions per 100 inpatient beds - last 7 days" to "Confirmed COVID-19 admissions per 100k - last 7 days". Since we were excluding this field by checking whether the header name contained the string "beds", the name change caused the filter to fail and for the column to be reported as hospital admissions (along with the actual hospital admissions).
We just use one column that begins "Confirmed COVID-19 admissions", so we can make the filter for this particular header a lot narrower to avoid future problems from field name changes. Also clean up the
retain_overheaderlogic a bit.Changelog
pull.pyFixes
Assertion error