Skip to content

[CTIS] New booster and vaccination indicators for Wave 13 #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

nmdefries
Copy link
Contributor

Description

Add new indicators to both API and contingency tables at FB's request.

Changelog

  • binary.R
  • contingency_indicators.R
  • variables.R

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly want to check on the multinomials here, to be sure they're right

if ("C17b" %in% names(input_data)) {
input_data$v_flu_vaccine_2021 <- input_data$C17b == 1
} else {
input_data$v_flu_vaccine_2021 <- NA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how many megabytes of NAs are in a typical data frame in a pipeline run...

@nmdefries nmdefries requested a review from capnrefsmmat March 7, 2022 14:47
Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, I think

@nmdefries
Copy link
Contributor Author

@krivard This is ready to merge and deploy.

@krivard krivard merged commit 8a7e958 into main Mar 8, 2022
@krivard krivard deleted the ndefries/wave13-new-indicators branch March 8, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants