Skip to content

[CTIS] Make split_options return list of character missing if all input values are NA #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jan 4, 2022

Description

General version of #1435 (see this comment) so that we don't need to add compensatory logic to handle the case when all values for a survey question are missing (NA).

Changelog

  • variables.R:
    • Add all-missing handling logic to split_options.
    • Set all split_options output to list format.
    • Remove compensatory logic in variable creation in code_vaccines
  • test-variables.R:
    • Test split_options behavior on character missing and logical missing.
    • Test is_selected behavior on character missing and logical missing too.

@nmdefries nmdefries marked this pull request as ready for review January 4, 2022 01:21
@nmdefries nmdefries requested a review from capnrefsmmat January 4, 2022 04:39
@nmdefries nmdefries requested a review from capnrefsmmat January 5, 2022 22:40
@nmdefries
Copy link
Contributor Author

@korlaxxalrok This is ready to merge.

@nmdefries
Copy link
Contributor Author

@krivard This is ready to merge.

@krivard krivard merged commit 43c9484 into main Jan 10, 2022
@krivard krivard deleted the splitoptions-robust-na branch January 10, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants