Skip to content

Add fields to validation log messages #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Add fields to validation log messages #1326

merged 2 commits into from
Oct 22, 2021

Conversation

qx-teo
Copy link
Contributor

@qx-teo qx-teo commented Oct 20, 2021

Description

Elastic can't create meaningful representations of logs now, since we store important information (e.g. geo_type, error_type) in a single message. We include these things in separate fields as well so that it's easier to parse information either offline or within Elastic dashboards.

Changelog

Itemize code/test/documentation changes and files added/removed.

  • report.py

Used ValidationFailures for warnings instead so that formatting remains consistent, fixed assert statements
@qx-teo qx-teo requested a review from nmdefries October 20, 2021 05:36
@krivard krivard merged commit b92109a into main Oct 22, 2021
@krivard krivard deleted the rewrite_log_errors branch October 22, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants