Skip to content

Suppress rapid_change_num_rows #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Suppress rapid_change_num_rows #1324

merged 2 commits into from
Oct 22, 2021

Conversation

qx-teo
Copy link
Contributor

@qx-teo qx-teo commented Oct 19, 2021

Description

Test constantly failing for covid_ag_raw_pct_positive since not all geo_ids have data every day, we suppress errors for this since it's a false positive

Changelog

Itemize code/test/documentation changes and files added/removed.

  • params.json.template for both quidel folder and ansible.

Test constantly failing for covid_ag_raw_pct_positive since not all geo_ids have data every day, we suppress errors for this since it's a false positive
@qx-teo qx-teo requested a review from nmdefries October 20, 2021 05:06
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting to verify that very different number of geos per day is expected behavior.

Only suppress errors for smaller geo_types
@qx-teo qx-teo requested a review from nmdefries October 20, 2021 16:46
@krivard krivard merged commit fdabd21 into main Oct 22, 2021
@krivard krivard deleted the quidel_rapid_change_rows branch October 22, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants