Skip to content

Set HSP-DV day_shift to 0 #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2021
Merged

Set HSP-DV day_shift to 0 #1317

merged 2 commits into from
Oct 13, 2021

Conversation

rumackaaron
Copy link
Contributor

Description

We had been shifting the reference date of the dv indicator one day ahead. We no longer want to do this.

Changelog

Itemize code/test/documentation changes and files added/removed.

  • config.py: DAY_SHIFT = 0

Fixes

@rumackaaron rumackaaron requested a review from krivard October 13, 2021 14:28
@krivard krivard changed the title Set day_shift to 0 Set HSP-DV day_shift to 0 Oct 13, 2021
krivard
krivard suggested changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests please

@rumackaaron
Copy link
Contributor Author

Done

krivard
krivard approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard krivard merged commit 3b84dbf into main Oct 13, 2021
@krivard krivard deleted the dv_day_shift branch October 13, 2021 18:19
@krivard
Copy link
Contributor

krivard commented Oct 13, 2021

@mariajahja please update the deployed HSP-DV code at your convenience.

@krivard krivard mentioned this pull request Oct 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rumackaaron @krivard