Fix GS files not transferring to delivery_dir #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in file extension check to GS files Moved delivery params up one level so that runner can parse delievery params
qx-teo
requested review from
sgsmob and
nmdefries
and removed request for
sgsmob
nmdefries
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix: GS was not updated in the API even though validator has been running. This is because the delivery params have been at the wrong level (under validation, rather than existing as its own set of params). We shift those params up a level, and also add in a file extension check to GS files to make sure that we aren't moving other non-csv files in ./receiving.
Changelog
Added in file extension check to GS files
Moved delivery params up one level so that runner can parse delivery params
Fixes