Skip to content

Combine summarize_* filter in surveys aggregation #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2021
Merged

Combine summarize_* filter in surveys aggregation #1296

merged 2 commits into from
Oct 11, 2021

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Oct 6, 2021 •
edited
Loading

Description

Combine column and row filters in summarize_indicators_day/summarize_aggregations_group function for small memory improvement (on my machine, minus a few GB at peak memory usage).

@nmdefries nmdefries requested a review from capnrefsmmat October 7, 2021 17:36
capnrefsmmat
capnrefsmmat requested changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch (and lol several GB from a single line). I think it can be simplified further though, if it matters

@nmdefries nmdefries requested a review from capnrefsmmat October 8, 2021 16:45
@krivard krivard merged commit cdee6c6 into main Oct 11, 2021
@krivard krivard deleted the combine-filter branch October 11, 2021 18:26
@krivard krivard mentioned this pull request Oct 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capnrefsmmat capnrefsmmat capnrefsmmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmdefries @capnrefsmmat @krivard