Refactor weekday calc into utils

[chinandrew]

Description

Refactor DV, CHNG, and Claims_hosp to use the same calc_adjustment (fc5c8dd)and weekday function (1175e5d and later) and move into delphi utils . CHNG and claims_hosp were previously using the same one while DV had a multi-column version.

Changelog

Itemize code/test/documentation changes and files added/removed.

• Add column argument to calc_adjustment and have it loop through each one.
• Update index management outside function
• Reshape returns weekday params to be 2D arrays universally
• Update utils linter config to accept single variable uppercase names (e.g. X)
• Have weekday take in column and scale arguments.

Fixes

• Fixes Move weekday.py into shared utils #1269

[chinandrew]

@mariajahja @rumackaaron For 👀 on this draft.

[rumackaaron]

Just noticed that we have no weekday tests. Would it be possible to confirm that the output of the indicators is unchanged by the refactor?

[chinandrew]

Just noticed that we have no weekday tests. Would it be possible to confirm that the output of the indicators is unchanged by the refactor?

Yea definitely would be a good idea. Are there any trivial input/outputs we could use to verify the minimization is working? Or at worst we can just rerun the old implementation on some test data (on the assumption it's working) and make sure the new one outputs the same values.

[rumackaaron]

Unfortunately, with the L1 smoothing I don't think there are trivial outputs that will work. I think the second suggestion makes sense.

[alexcoda]

@rumackaaron Added some tests for the weekday.py methods. The expected values in the tests were generated by running the test values through the methods on main.