Skip to content

Minor clean up of changehc sensor updating #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 18, 2021
Merged

Minor clean up of changehc sensor updating #1266

merged 5 commits into from
Oct 18, 2021

Conversation

alexcoda
Copy link
Contributor

Description

Some minor cleanup, no functional changes

Changelog

  • Remove redundant start/end date setting within changehc. This statement was never executed because we always specify the start and end dates.
  • Simplify logic for handling signals, since only 1 signal is being processed within CHCSensorUpdate.update_sensor.
  • Remove unnecessary uses of .loc throughout all indicators.

- Remove redundant start/end date check
- Simplify logic for handling signals, since only 1 signal is being processed
@alexcoda alexcoda requested a review from krivard September 26, 2021 21:58
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard krivard merged commit ef13336 into main Oct 18, 2021
@krivard krivard deleted the clean-up branch October 18, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants