Skip to content

Switch indicators from logging to delphi_utils structured logger #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2021

Conversation

chinandrew
Copy link
Contributor

Description

CDC Covidnet, CHNG, and DV were using the standard library logger. This pr switches them to use the structured logger created by delphi_utils.

Changelog

Itemize code/test/documentation changes and files added/removed.

  • Refactor indicators to use structured logger, passing it in to functions where necessary.

@chinandrew chinandrew requested a review from krivard September 22, 2021 03:03
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about use of format strings/args in standard library logger vs structlog

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @mariajahja we'll want to deploy this to doctor-visits

@krivard krivard merged commit cdd12ff into main Sep 27, 2021
@krivard krivard deleted the use-structured-logger branch September 27, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants