Skip to content

Standardize logging #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 22, 2021
Merged

Standardize logging #1256

merged 12 commits into from
Sep 22, 2021

Conversation

alexcoda
Copy link
Contributor

@alexcoda alexcoda commented Sep 19, 2021

Description

Standardizes to use the structured logger instead of plain print statements across all indicators.

Note that there are still some indicators which just use logging directly rather than the structured logger. This PR is focused just at removing print statements as a first step.

Changelog

  • Simplified use of some helper methods in delphi_combo_cases_and_deaths/run.py. No functional changes.
  • Removed some print statements from quidel and quidel_covidtest associated with ValueErrors being raised.

Fixes

  • Fixes a mismatch between the error message and what was actually being checked in the quidel and quidel_covidtest data_tools.py

@alexcoda
Copy link
Contributor Author

@krivard ready for review

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(conservation of % signs)

@alexcoda alexcoda requested a review from krivard September 22, 2021 01:26
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard krivard merged commit c4a57fc into cmu-delphi:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants