Skip to content

Update setup.py files to "Python :: 3.8" annotation #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2021
Merged

Update setup.py files to "Python :: 3.8" annotation #1251

merged 1 commit into from
Sep 16, 2021

Conversation

dshemetov
Copy link
Contributor

Description

Small annotation in setup.py files for each indicator for consistency with Makefiles.

Changelog

Change Python :: 3.7 to Python :: 3.8.

@dshemetov dshemetov requested a review from qx-teo September 15, 2021 21:51
qx-teo
qx-teo approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@qx-teo qx-teo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

krivard
krivard approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that we are in fact using Python 3.8 on primary, so this is a low-risk change even though it touches all our indicators at once.

@krivard krivard merged commit 7937a68 into main Sep 16, 2021
@krivard krivard deleted the removepy37refs branch September 16, 2021 14:41
@krivard krivard mentioned this pull request Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krivard krivard krivard approved these changes

@qx-teo qx-teo qx-teo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dshemetov @krivard @qx-teo