Skip to content

Un-retire schooling indicators from sirCAL #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Conversation

nmdefries
Copy link
Contributor

Description

Revert #1192. Schooling indicators are now turned back on.

Changelog

  • Remove *_school_fulltime and *_school_parttime from sirCAL retired signals for fb-survey.

@nmdefries nmdefries requested a review from krivard September 14, 2021 21:46
@krivard
Copy link
Contributor

krivard commented Sep 15, 2021

This is difficult to review due to the length of the list. Could we take this opportunity to add some whitespace for readability?

Something like

"retired-signals": [
    "item1", "witem1", "item2", "witem1", ...[just out to 80 characters]
    "itemN", "witemN"
],

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 excellent, thanks!

@krivard krivard merged commit 0b5388c into main Sep 15, 2021
@krivard krivard deleted the turn-schooling-inds-back-on branch September 15, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants