Make convex solver more robust for weekday correction #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krivard
reviewed
Aug 24, 2021
krivard
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Great! @korlaxxalrok can you use your cosmic powers to figure out how we can update the code in Maria's directory on bigchunk-dev-03?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the doctor visits indicator, we use cvxpy to solve an optimization problem that provides a weekday correction. This solver is not always robust, occasionally it will fail if the magnitude of the objective function is too large. A quick and dirty way to make it more robust is to divide the objective function by some large number.
Changelog
weekday.py: Try up to four times to rescale the objective function, up from two times.Fixes