Skip to content

Support upload of raceeth microdata in Makefile #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2021

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Aug 18, 2021

Description

Put #1183 into production.

Changelog

  • Add make target to upload race-eth microdata files to protected-race-ethnicity-data/ dir. Runs as part of pipeline target.
  • Add raceeth microdata dir to clean and tidy targets.
  • Add individual_raceeth_dir and produce_individual_raceeth default settings to the template production params file.
  • Turn on produce_individual_raceeth in the params make target.

@krivard
Copy link
Contributor

krivard commented Aug 18, 2021

Would you add the new keys to params.json.template and params.json.production.template please?

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard
Copy link
Contributor

krivard commented Oct 7, 2021

Should I wait for Alex on this or go ahead and merge once it finishes building?

Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve provided @krivard has looked at the Make and agrees that the raceeth files will end up in SFTP under protected-race-ethnicity-data/, and won't accidentally end up elsewhere

@capnrefsmmat
Copy link
Contributor

Also note that whatever script runs monthly-files.R should also run it on the raceeth data each month, to produce monthly race/ethnicity rollups.

@krivard krivard self-requested a review October 7, 2021 19:05
@nmdefries
Copy link
Contributor Author

I haven't seen any scripts or make targets that do the monthly rollup. @krivard is that committed to the repo somewhere?

@krivard
Copy link
Contributor

krivard commented Oct 8, 2021

Here's the monthly rollup builder:
https://github.com/cmu-delphi/covidcast-indicators/blob/main/facebook/monthly-files.R

It's called by a local script that we probably should check into the repo. Recommend addressing posting monthly rollups of raceeth data in a separate PR.

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Makefile changes are legit and won't put raceeth data anywhere except on purpose.

@krivard
Copy link
Contributor

krivard commented Oct 8, 2021

Waiting until Monday to merge this just in case we need to do an emergency deploy of main this afternoon

@krivard krivard merged commit 0bc5a7d into main Oct 11, 2021
@krivard krivard deleted the produce-microdata-raceeth branch October 11, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants