Skip to content

Add NAN code support to HHS Facilities #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

dshemetov
Copy link
Contributor

Description

Work as part #838.

Changelog

  • Add three missingness columns, default to NA for "sample_size" and "stderr" columns
  • Now codes the value "-999,999", which stands for the range [0-4], as 2 instead of nan

Fixes

@dshemetov dshemetov mentioned this pull request Apr 13, 2021
17 tasks
@dshemetov dshemetov force-pushed the nans_hhs_facilities branch 2 times, most recently from 647f460 to dd43fb9 Compare April 26, 2021 23:02
@dshemetov dshemetov force-pushed the nans_hhs_facilities branch from dd43fb9 to 7ed593f Compare April 27, 2021 20:04
* add missing columns
* change -999999 entries to 1.5 (average of [0-3] data range)
@dshemetov dshemetov requested review from a team and jingjtang and removed request for a team November 10, 2021 21:55
Copy link
Contributor

@jingjtang jingjtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krivard krivard merged commit 63633bb into cmu-delphi:main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants