Skip to content

Add nancodes enum util #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Add nancodes enum util #1000

merged 1 commit into from
Apr 13, 2021

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Apr 10, 2021

Description

This is part of #838. Adds the nancode constants used throughout the indicators.

Changelog

Add the nancodes.py of constants.

Fixes

@chinandrew chinandrew requested a review from nmdefries April 12, 2021 15:38
@dshemetov dshemetov force-pushed the nancodes_nans branch 2 times, most recently from 3c01c09 to 96bd3da Compare April 12, 2021 18:23
@@ -0,0 +1,19 @@
"""Unified not-a-number codes for the indicators.

Currently requires a manual sync between the covidcast-indicators
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this wont be true once we deploy to pypi right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I can take it out.

Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@chinandrew chinandrew merged commit b277922 into cmu-delphi:main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants