-
Notifications
You must be signed in to change notification settings - Fork 37
add singel-transaction option #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/171000843 The labels on this github issue will be updated when the story is started. |
|
@@ -41,6 +41,9 @@ for dbname in ${DATABASES[@]}; do | |||
--use-list=${TMP_LIST_FILE} \ | |||
--if-exists \ | |||
--clean \ | |||
<% if p("postgres.single-transaction") %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramonskie Thanks for the PR. The empty line left behind by the tag after the erb processing causes the "${BBR_ARTIFACT_FILE_PATH}"
line not to be concatenated to the restore command.
I suggest to create a variable that contains the --single-transaction
only if the new property is specified; then you can unconditionally use the variable with the continuation character in the restore command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed the \ so that even when false an empty line will be added to the command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
followed your advise and putted it in to a variable.
otherwise there would be to much empty line with \
in the command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
added the single transaction option as discused in #54