Skip to content

Make http://citationstyles.org/ and subdomains HTTPS #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adam3smith opened this issue Mar 10, 2018 · 6 comments
Closed

Make http://citationstyles.org/ and subdomains HTTPS #37

adam3smith opened this issue Mar 10, 2018 · 6 comments
Assignees

Comments

@adam3smith
Copy link
Member

https://blog.cloudflare.com/secure-and-fast-github-pages-with-cloudflare/

Who has control over the registration (which is needed for this)? Is that still at CHNM?

@rmzelle
Copy link
Member

rmzelle commented Mar 10, 2018

There are indications that GitHub is (finally!) starting to slowly roll out HTTPS support for custom domains, so I would just wait and not bother with the Cloudflare hack. See isaacs/github#156 (comment) for recent progress on this issue.

For http://docs.citationstyles.org/ we're dependent on hosting by https://readthedocs.org/, so that's a separate issue, see readthedocs/readthedocs.org#2652 (comment).

(P.S. https://discourse.citationstyles.org/ is also already HTTPS)

@rmzelle
Copy link
Member

rmzelle commented Mar 10, 2018

Some good news already: I was able to enable "Enforce HTTPS" for https://formatter.citationstyles.org/ and https://validator.citationstyles.org/, which are now served over HTTPS. Per the issue linked above, it looks like GitHub is a little further along with third-level hostnames like https://formatter.citationstyles.org/ than with second-level hostnames like http://citationstyles.org/ (isaacs/github#156 (comment)). Can't enable HTTPS for http://citationstyles.org/ yet.

@jayvdb
Copy link

jayvdb commented Mar 10, 2018

You may want to try https://netlify.com which provides this feature already, and more.

@rmzelle rmzelle changed the title Make the site https using Cloudflare Make http://citationstyles.org/ and subdomains HTTPS Mar 12, 2018
@rmzelle
Copy link
Member

rmzelle commented Mar 12, 2018

You may want to try https://netlify.com which provides this feature already, and more.

I rather not, especially since GitHub seems to be finally rolling this out, probably driven by Google's decision to mark all HTTP sites as non-secure by July 2018: https://security.googleblog.com/2018/02/a-secure-web-is-here-to-stay.html. I assume we'll get native HTTPS support for GitHub Pages if we just wait another month or two.

@rmzelle
Copy link
Member

rmzelle commented May 2, 2018

Earlier today GitHub enabled HTTPS for all custom domains, so we've just activated it for https://citationstyles.org/. Dan Stillman from Zotero kindly updated the A record (domain is still at CHNM), and I had to fix a small mixed content issue with our theme (solved by specifying the HTTPS domain in _config.yml per mmistakes/minimal-mistakes#1318 (comment)), but everything seems to work now. I enabled "Enforce HTTPS".

So the only remaining HTTP part is http://docs.citationstyles.org/, which needs a change at Read the Docs (as I wrote above at #37 (comment)).

@rmzelle
Copy link
Member

rmzelle commented May 9, 2018

Created a separate issue for http://docs.citationstyles.org/. Since the rest is HTTPS now, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants