forked from usnistgov/CASE-Utilities-Python
-
Notifications
You must be signed in to change notification settings - Fork 3
Release 0.2.0 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python Software Foundation is supporting Python 3.6 until 2021-12-23. CASE should test its tooling in Python 3.6 until that Python release reaches end-of-life. This patch is somewhat an XFAIL - I ran the unit tests in an Ubuntu 18.04 machine and found a feature used in a test is supported in Python >= 3.7. A follow-on patch will correct that issue. Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
The prior patch worked in my local environment, but missed a nuance of Python 3.8 being available in Github's runner, though 3.6 is the action's configured version. The Makefile PYTHON3 variable does a newest-version-first search, so virtualenv wasn't found at runtime. The name of the action's Python 3 command was found via the home page of the setup-python action: https://github.com/marketplace/actions/setup-python Signed-off-by: Alex Nelson <[email protected]>
Test in Python 3.6
References: * [AC-154] XML Schema datatype prefix needs to be explicit in all examples Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Import compact.py fixes
IANA lists `application/ld+json` as a media type, including the `.jsonld` file extension, here: https://www.iana.org/assignments/media-types/application/ld+json via https://www.iana.org/assignments/media-types/media-types.xhtml via https://w3c.github.io/json-ld-syntax/#iana-considerations Signed-off-by: Alex Nelson <[email protected]>
Signed-off-by: Alex Nelson <[email protected]>
Recognize jsonld extension
References: * [AC-139] FAQ question - Does CASE require hex data be entered uppercase or lowercase? Signed-off-by: Alex Nelson <[email protected]>
Add tests for hexBinary
References: * [AC-183] Apply minimal CASE-Utilities-Python updates to use CASE 0.4.0 and UCO 0.6.0
Signed-off-by: Alex Nelson <[email protected]>
References: * [AC-183] Apply minimal CASE-Utilities-Python updates to use CASE 0.4.0 and UCO 0.6.0 Signed-off-by: Alex Nelson <[email protected]>
References: * [AC-183] Apply minimal CASE-Utilities-Python updates to use CASE 0.4.0 and UCO 0.6.0 * [UCO OC-19] (CP-24) UCO might not need xsd:long Signed-off-by: Alex Nelson <[email protected]>
This was done manually after review of generated files, due to noisy and uninformative blank node renames being introduced for unknown reasons. References: * [AC-183] Apply minimal CASE-Utilities-Python updates to use CASE 0.4.0 and UCO 0.6.0 * [UCO OC-19] (CP-24) UCO might not need xsd:long Signed-off-by: Alex Nelson <[email protected]>
References: * [AC-183] Apply minimal CASE-Utilities-Python updates to use CASE 0.4.0 and UCO 0.6.0 Signed-off-by: Alex Nelson <[email protected]>
References: * [AC-178] Add website repository's sample runner to CASE-Utilities-Python repository Signed-off-by: Alex Nelson <[email protected]>
This does not address the CI-reported python3.6 error, but it is a necessary fix in the meanwhile. References: * [AC-178] Add website repository's sample runner to CASE-Utilities-Python repository Signed-off-by: Alex Nelson <[email protected]>
numpy, a pandas dependency, required Python > 3.7 as of version 1.20.0. Hence, case_sparql_select cannot import pandas in a Python 3.6 environment. This patch adds steps to disable dependency installation and tests for case_sparql_select if Python is detected to be < 3.7.x. As a reminder, Python 3.6 goes EOL on 2021-12-23. By or at that time, 3.6 will be removed from this project. References: * [AC-178] Add website repository's sample runner to CASE-Utilities-Python repository * [PEP-0494] https://www.python.org/dev/peps/pep-0494/#and-beyond-schedule * [numpy 1.20.0] https://pypi.org/project/numpy/1.20.0/ Signed-off-by: Alex Nelson <[email protected]>
This speeds local 'make check' round trips while developing, though at the trade of having to push dependencies into more localized Make recipes. References: * https://pip.pypa.io/en/stable/reference/pip_install/#cmdoption-e Signed-off-by: Alex Nelson <[email protected]>
Use pip -e flag
Issue encountered while testing for AC-182. References: * [AC-178] Add website repository's sample runner to CASE-Utilities-Python repository * [AC-182] Have website track CASE-Utilities-Python as submodule Signed-off-by: Alex Nelson <[email protected]>
Add JSON-LD output code path test for case_sparql_construct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.