Add CDO concept typo-checker based on set-differencing URIRefs using CDO prefixes #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CDO prefixes A follow-on patch will regenerate Make-managed files. References: * #40 Signed-off-by: Alex Nelson <[email protected]>
Syntax errors or other code halts will cause _$@ to be empty. Signed-off-by: Alex Nelson <[email protected]>
This file records the history of CDO IRIs that are ontology IRIs or somehow related to ontology versioning. A follow-on patch will add the scripts that generated this file. For CI and git-bisect purposes, the patch storing the generated file needs to be committed first. References: * #40 Signed-off-by: Alex Nelson <[email protected]>
A follow-on patch will regenerate Make-managed files. References: * #40 Signed-off-by: Alex Nelson <[email protected]>
References: * #40 Signed-off-by: Alex Nelson <[email protected]>
kchason
approved these changes
Nov 17, 2022
ajnelson-nist
added a commit
to casework/CASE-Corpora
that referenced
this pull request
Nov 22, 2022
The new typo checking feature of `case_validate` flags usage of the IRI serving as the `uco-core:` prefix as an unrecognized concept. Rather than determine how to encode a definition for the prefix IRI within the ontology, this patch removes usage of `sh:declare`, due to downstream side-effects noted during development of UCO Issue 457. No effects were observed on Make-managed files. References: * casework/CASE-Utilities-Python#77 * ucoProject/UCO#457 Signed-off-by: Alex Nelson <[email protected]>
ajnelson-nist
added a commit
to casework/CASE-Implementation-GNU-Time
that referenced
this pull request
Dec 16, 2022
This patch does not apply `pre-commit`; that will be applied in a follow-on patch. Concept typo-checking is now delegated to the `case_validate` typo-checker. This removes the CASE-Examples-QC dependency. A follow-on patch will regenerate Make-managed files. References: * casework/CASE-Utilities-Python#77 Signed-off-by: Alex Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Issue 40.
This PR implements in
case_validatethe CDO concept set-differencing strategy used in CASE-Examples-QC. That strategy was discussed in #40.The new behavior is:
--allow-warningswill let these warnings still pass validation. If that flag is not present,case_validatewill exit 1, and give a description (through another warning) of why the tool exited 1 even thoughConforms: truecame from the SHACL validation results.The data graph is SHACL-conformant with the CDO ontologies, but nonexistent-concept references raise Warnings with this tool. Please either correct the concept names in the data graph; use the --ontology-graph flag to pass a corrected CDO ontology file, also using --built-version none; or, use the --allow-warnings flag.warnings.warnfunction is used to raise these warnings.