Move testing dependencies to setup.cfg #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the packages listed in `tests/requirements.txt` into `setup.cfg`. This is done to: * Reduce complexity of downstream projects that wish to inherit testing dependencies. E.g. currently the `tests/requirements.txt` file is loaded via incorporating `case-utils` as a submodule in at least two projects (`case_exiftool`, `case_gnu_time`). * Expose test requirements for supply-chain review via package metadata. The feature name is for the test requirements is `testing`, inheriting the name from Python's `setuptools`. This feature is added knowing that, once added, it should not be removed, per this best practice in the PyPA guidance: > Best practice: if a project ends up no longer needing any other > packages to support a feature, it should keep an empty requirements > list for that feature in its extras_require argument, so that packages > depending on that feature don’t break (due to an invalid feature > name). There were no effects observed on Make-managed files. References: * https://github.com/casework/CASE-Implementation-ExifTool/blob/0.5.0/tests/Makefile#L43-L45 * https://github.com/casework/CASE-Implementation-GNU-Time/blob/0.7.0/tests/Makefile#L56-L58 * https://github.com/pypa/setuptools/blob/v67.6.1/setup.cfg#L42 * https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies Signed-off-by: Alex Nelson <[email protected]>
kchason
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See patch 1 for description of the patch series.