Skip to content

Workflows #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 2, 2023
Merged

Workflows #1

merged 9 commits into from
Jun 2, 2023

Conversation

kchason
Copy link
Member

@kchason kchason commented Jun 2, 2023

Adds CI workflows for the following:

  • pre-commit checks
  • CASE validation on any .json files in the data/ directory
  • Build and run the three language projects

@kchason kchason requested a review from ajnelson-nist June 2, 2023 17:17
Copy link
Member

@ajnelson-nist ajnelson-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer some of the test matrices be expanded a bit. I forget if matrix-nesting can be done precisely at the spots I suggested. I won't block the PR if you'd like to merge now.

@ajnelson-nist
Copy link
Member

How about we merge this now and address the comments I made in follow-on PRs. They should all be straightforward if I understand the syntax and nesting right, but it might be a few round-trips with GitHub Actions.

@ajnelson-nist ajnelson-nist merged commit 942341c into main Jun 2, 2023
@ajnelson-nist ajnelson-nist deleted the ci-workflows branch June 2, 2023 17:41
@ajnelson-nist
Copy link
Member

All of my comments have been or are being addressed in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants