Skip to content

Fix translations text not being found by getByText #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

pierrezimmermannbam
Copy link
Collaborator

Summary

Pr is still a draft. Fixes #937

Test plan

@pierrezimmermannbam pierrezimmermannbam marked this pull request as draft May 1, 2022 19:42
@pierrezimmermannbam pierrezimmermannbam changed the title chore: make queries by text based on the tree Fix translations text not being found by getByText May 1, 2022
@mdjastrzebski
Copy link
Member

This issue is related to architecture discussion in #972.

ReactTestRendererNode seems to be better suited for handling text related stuff, but otherwise we rely on ReactTestInstance it would be great to have an easy way of getting ReactTestRendererNode from ReactTestInstance. It seems that React Test Renderer source has such function but unfortunately it is not exported and we are limited to calling toJSON on ReactTestRenderer instance.

@mdjastrzebski
Copy link
Member

Closing as changes contained it the PR would break other features of RNTL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Unable to find an element with text: "My text", while that text exist.
2 participants