refactor: re-organise regular (non A11y) queries by predicate #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
changed the title
MattAgn
reviewed
May 2, 2022
src/queries/unsafeProps.ts
Outdated
|
|
||
| // Removed aliases | ||
| // TODO: remove in the next release | ||
| queryByName: () => void; |
There was a problem hiding this comment.
this should be in the unsafeByName file I guess (same for the other mentions of byName in the rest of the file)
There was a problem hiding this comment.
This is unmodified name from before the PR and it's there for easier code migration for users.
That being said this code deprecation is quite old now, all users should have migrated a long time ago, so I would be for removing these legacy aliases. @thymikee @AugustinLF wdyt about remove all these deprecated aliases?
There was a problem hiding this comment.
I'm all for removing deprecated functions
There was a problem hiding this comment.
I've removed all removed functions error messages.
MattAgn
reviewed
May 2, 2022
AugustinLF
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-organise internal queries code by predicate typ #325
Scope of changes
GetByAPI,QueryByAPIandFindByAPItypes and functions with per query type and functions (ByXxxQueries,bindByXxxQueries)src/helperstosrc/queriesNote: Changes consist of moving types around and tweaking exports. In order to reduce PR size and potential for bugs I refrained from doing any query logic changes.
Note 2: This is the reason why I intend to make a separate PR for A11y queries as there we would require some code changes.
Note 3: There are certain inconsistencies when it comes to existence (or not) of certain deprecated query aliases. I did not make any changes but kept the existing status as is. Let me know if I should remove old aliases or fill in the missing ones
Note 4: We have really awesome automated tests!
Test plan