Extract tests by queries #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 7, 2021 15:59
MattAgn
changed the title
|
@thymikee are those tests ok for you? is it the kind of refactor you had in mind? |
|
Yup, but since this touches tests, I need to take a double care in verifying we don't miss any use cases we covered. Struggling to find time at the moment, but will get there :) |
|
Sure, totally understand! Tell me if I can be of any help :) |
|
|
||
| test('getByDisplayValue, queryByDisplayValue', () => { | ||
| const { getByDisplayValue, queryByDisplayValue } = render(<Banana />); | ||
| const input = getByDisplayValue(/custom/i); |
There was a problem hiding this comment.
You could place that regex and the next ones at the top similar to texts with a proper name. It would be consistent and helpful for future readings.
There was a problem hiding this comment.
Feel free to address that as a followup
thymikee
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the follow up of this PR and this PR addressing this issue.
Its purpose is to re-organize the tests of the queries byDisplayValue, byTestId, byText and byPlaceholderText and have them each in a separate file (for now they all are in the findByApi.test.js and render.test.js files) .
Test plan
Tests should not change and only be moved to the proper query files