-
Notifications
You must be signed in to change notification settings - Fork 273
feat: support pointerEvents #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let's support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add tests for following scenarios:
- Firing event on the same element which has
pointerEvents="none"
(<Text onPress={handlePress} pointerEvents="none" />
) - Firing event on the same element which has
pointerEvents="box-none"
(<Text onPress={handlePress} pointerEvents="box-none" />
) - Firing event on the same element which has
pointerEvents="box-only"
(<Text onPress={handlePress} pointerEvents="box-only" />
)
I don't think that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would still be nice to have some tests which trigger onPress
on the same element that has pointerEvents
547ed59
to
306e24b
Compare
Summary
This PR allows handling test cases that use
pointerEvents
which was mentioned in #650. I'm not sure if we should also additionally handle thebox-none
value.Fixes #650
Test plan
I've added 3 tests that check pointerEvents
none
andbox-only
and also pointerEventsnone
with nested views.