Enable partial matching #546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustinLF
commented
Sep 14, 2020
| if (text === textToTest) { | ||
| return { exact: true }; | ||
| } else { | ||
| if (textToTest.includes(text)) { |
There was a problem hiding this comment.
Using includes here posed a lot of problem since it means that the parent nodes will also match. Hence the significant update to the logic.
AugustinLF
commented
Sep 14, 2020
| @@ -95,13 +112,46 @@ const getNodeByTestId = (node, testID) => { | |||
| : testID.test(node.props.testID); | |||
| }; | |||
|
|
|||
| export const nonErroringGetByText = (instance: ReactTestInstance) => | |||
| function nonErroringGetByTextFn(text: string | RegExp) { | |||
| const matchingInstances = instance.findAll((node) => | |||
There was a problem hiding this comment.
Since we switch from find to findAll, the implementation doesn't throw anymore if no match is found. So I updated that so we can still use this implementation in queryByText (which shouldn't throw).
|
How does it relate to #541? |
|
Don't be sorry! Too bad you didn't see the PR earlier. However, if you feel like it, I'd appreciate reviewing that PR to make it right :) |
|
I'm on it, will run my tests against that implementation to see if it behaves as I'd expect it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up of #489, I'm trying to make the migration from
@5.Xto@7.Xin a fairly large project. Another missed breaking change is that the current implementation doesn't permit "partial matches", as isrender(<Text>Hello World</Text>).getByText('Hello')will throw. We have a lot of tests relying on this pattern (which is also the way web behaves). In this PR I fixed that.This is technically a breaking change since some people might rely on
getByTextthrowing in this case. But I do believe that we should seek for an API as close as possible from@testing-library/react.Test plan
I added several tests that should cover the different edge cases related to this change.