-
Notifications
You must be signed in to change notification settings - Fork 274
Switch to Yarn workspaces #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Steps leading to this change:
|
I'm not convinced we need |
It was more for future cases. In case another package was introduced which had different flow configurations from the global one |
Such future may (most likely) never come. There's no reason to add more dependencies to the project "just in case". Only when necessary – e.g. we have long-term plan of supporting such use case. Which we don't. |
@@ -36,21 +36,21 @@ jobs: | |||
- attach_workspace: | |||
at: ~/react-native-testing-library | |||
- run: | | |||
cd packages/react-native-testing-library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting and type checks should go from the root, please remove and adjust configuration if needed
"json" | ||
], | ||
"rootDir": "./src" | ||
"devDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, there's no need to differentiate between deps and devDeps in workspace root, I don't mind it though, your call :)
"jest": "*", | ||
"react": "*", | ||
"react-native": "*", | ||
"react-test-renderer": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get rid of *
in our dev deps and bring back the versions we had in original package.json? I don't mind having *
in examples though
Summary
Refactoring the codebase to use yarn workspaces. Resolved #493
Installation