feat: add getQueriesForElement alias to within
#461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
changed the title
getQueriesForElement alias to within
thymikee
reviewed
Jul 28, 2020
| @@ -306,6 +307,18 @@ const withinGet: Array<ReactTestInstance> = [ | |||
| within(instance).getByRole('button'), | |||
| within(instance).getByA11yState({ busy: true }), | |||
| within(instance).getByA11yValue({ min: 10 }), | |||
| getQueriesForElement(instance).getByText('Test'), | |||
There was a problem hiding this comment.
I wish we could do something like within === getQueriesForElement instead, but TS is structural and this will likely pass anyway. And I wouldn't like to resort to hacks like described here
thymikee
approved these changes
Jul 28, 2020
thymikee
pushed a commit
that referenced
this pull request
Jul 30, 2020
thymikee
pushed a commit
that referenced
this pull request
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TL/RN v6 has provided
getQueriesForElementfor scoping queries to given element & it's children. RNTL v2 had a similarwithinfunction. Both of these were modeled on similar RTLs helper. In RTL both names are available (as alias) to provide the same function.I've added
getQueriesForElementas an alias towithin.Resolves #457
Test plan