Skip to content

feat: introduce ByLabelText, ByRole and ByHintText a11y aliases #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 21, 2020
Merged

feat: introduce ByLabelText, ByRole and ByHintText a11y aliases #445

Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4038af1
feat: Add alias accessibilityLabel queries to assist in migrating fro…
ryanjwessel Jul 17, 2020
1a433e6
feat: Add alias accessibilityHint queries to assist in migrating from…
ryanjwessel Jul 17, 2020
97b8c3b
feat: Add alias accessibilityRole queries to assist in migrating from…
ryanjwessel Jul 17, 2020
041a70b
feat: Add to A11yAPI types to include the newly-aliased queries for l…
ryanjwessel Jul 17, 2020
2a69935
test: Add tests for newly-aliased label, hint, and role a11y queries
ryanjwessel Jul 17, 2020
82f2b4d
test: Add newly-alised a11y queries to the index typings test file
ryanjwessel Jul 17, 2020
f19f940
docs: Add query aliases for testing library migrators to Queries docu…
ryanjwessel Jul 20, 2020
be98ebe
test: Consolidate aliased query tests into shared tests. FIXME's wher…
ryanjwessel Jul 20, 2020
b6910f2
test: Update a11yAPI tests to assert referential equality for query a…
ryanjwessel Jul 21, 2020
2e1c201
refactor: apply Prettier formatting to a11yAPI test file
ryanjwessel Jul 21, 2020
26216f3
fix: address typos in CONTRIBUTING.md
ryanjwessel Jul 21, 2020
abee149
test: Separate referential quality assertion tests for query aliases …
ryanjwessel Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 66 additions & 18 deletions src/helpers/a11yAPI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,36 +103,84 @@ const a11yAPI = (instance: ReactTestInstance): A11yAPI =>
...makeQuery(
'accessibilityLabel',
{
getBy: ['getByA11yLabel', 'getByAccessibilityLabel'],
getAllBy: ['getAllByA11yLabel', 'getAllByAccessibilityLabel'],
queryBy: ['queryByA11yLabel', 'queryByAccessibilityLabel'],
queryAllBy: ['queryAllByA11yLabel', 'queryAllByAccessibilityLabel'],
findBy: ['findByA11yLabel', 'findByAccessibilityLabel'],
findAllBy: ['findAllByA11yLabel', 'findAllByAccessibilityLabel'],
getBy: ['getByA11yLabel', 'getByAccessibilityLabel', 'getByLabelText'],
getAllBy: [
'getAllByA11yLabel',
'getAllByAccessibilityLabel',
'getAllByLabelText',
],
queryBy: [
'queryByA11yLabel',
'queryByAccessibilityLabel',
'queryByLabelText',
],
queryAllBy: [
'queryAllByA11yLabel',
'queryAllByAccessibilityLabel',
'queryAllByLabelText',
],
findBy: [
'findByA11yLabel',
'findByAccessibilityLabel',
'findByLabelText',
],
findAllBy: [
'findAllByA11yLabel',
'findAllByAccessibilityLabel',
'findAllByLabelText',
],
},
matchStringValue
)(instance),
...makeQuery(
'accessibilityHint',
{
getBy: ['getByA11yHint', 'getByAccessibilityHint'],
getAllBy: ['getAllByA11yHint', 'getAllByAccessibilityHint'],
queryBy: ['queryByA11yHint', 'queryByAccessibilityHint'],
queryAllBy: ['queryAllByA11yHint', 'queryAllByAccessibilityHint'],
findBy: ['findByA11yHint', 'findByAccessibilityHint'],
findAllBy: ['findAllByA11yHint', 'findAllByAccessibilityHint'],
getBy: ['getByA11yHint', 'getByAccessibilityHint', 'getByHintText'],
getAllBy: [
'getAllByA11yHint',
'getAllByAccessibilityHint',
'getAllByHintText',
],
queryBy: [
'queryByA11yHint',
'queryByAccessibilityHint',
'queryByHintText',
],
queryAllBy: [
'queryAllByA11yHint',
'queryAllByAccessibilityHint',
'queryAllByHintText',
],
findBy: ['findByA11yHint', 'findByAccessibilityHint', 'findByHintText'],
findAllBy: [
'findAllByA11yHint',
'findAllByAccessibilityHint',
'findAllByHintText',
],
},
matchStringValue
)(instance),
...makeQuery(
'accessibilityRole',
{
getBy: ['getByA11yRole', 'getByAccessibilityRole'],
getAllBy: ['getAllByA11yRole', 'getAllByAccessibilityRole'],
queryBy: ['queryByA11yRole', 'queryByAccessibilityRole'],
queryAllBy: ['queryAllByA11yRole', 'queryAllByAccessibilityRole'],
findBy: ['findByA11yRole', 'findByAccessibilityRole'],
findAllBy: ['findAllByA11yRole', 'findAllByAccessibilityRole'],
getBy: ['getByA11yRole', 'getByAccessibilityRole', 'getByRole'],
getAllBy: [
'getAllByA11yRole',
'getAllByAccessibilityRole',
'getAllByRole',
],
queryBy: ['queryByA11yRole', 'queryByAccessibilityRole', 'queryByRole'],
queryAllBy: [
'queryAllByA11yRole',
'queryAllByAccessibilityRole',
'queryAllByRole',
],
findBy: ['findByA11yRole', 'findByAccessibilityRole', 'findByRole'],
findAllBy: [
'findAllByA11yRole',
'findAllByAccessibilityRole',
'findAllByRole',
],
},
matchStringValue
)(instance),
Expand Down